RE: [PATCH iwl-net 03/12] ice: E822: cancel offset verification work during reset preparation

> -----Original Message-----
> From: Keller, Jacob E <[email protected]> 
> Sent: Friday, August 21, 2026 5:13 PM
> To: Intel Wired LAN <[email protected]>
> Cc: [email protected]; Machnikowski, Maciej <[email protected]>; Nguyen, Anthony L <[email protected]>; Korba, Przemyslaw <[email protected]>; Nitka, Grzegorz <[email protected]>; Oros, Petr <[email protected]>; Nowlin, Alexander <[email protected]>; Bross, Kevin <[email protected]>; Cavatur, Ranjit <[email protected]>; Keller, Jacob E <[email protected]>; Karol Kolacinski <[email protected]>; Loktionov, Aleksandr <[email protected]>; Kubalewski, Arkadiusz <[email protected]>; Korba, Przemyslaw <[email protected]>; Machnikowski, Maciej <[email protected]>
> Subject: [PATCH iwl-net 03/12] ice: E822: cancel offset verification work during reset preparation
> 
> From: Karol Kolacinski <[email protected]>
> 
> Cancel the offset verification delayed work (ov_work) during PTP reset preparation to prevent it from running concurrently with the reset sequence.
> 
> Without this, ice_ptp_wait_for_offsets() can execute during a reset, find that ice_is_reset_in_progress() is true, and re-queue itself in a tight loop. Meanwhile, the reset path in ice_ptp_rebuild_owner() calls ice_ptp_port_phy_restart(), which starts a new ov_work. This results in two ov_work instances running simultaneously, racing over the PHY offset registers and the calibrating flag.
> 
> Cancel ov_work in ice_ptp_prepare_for_reset() alongside the existing cancellation of the Tx tracker. The comment in the existing code already documents that ov_work interference during reset is a concern but > only cancels it during ice_ptp_release().
> 
> Fixes: 4809671015a1 ("ice: Fix E810 PTP reset flow")
> Signed-off-by: Karol Kolacinski <[email protected]>
> Reviewed-by: Aleksandr Loktionov <[email protected]>
> Signed-off-by: Arkadiusz Kubalewski <[email protected]>
> Signed-off-by: Przemyslaw Korba <[email protected]>
> Reviewed-by: Maciek Machnikowski <[email protected]>
> ---
>  drivers/net/ethernet/intel/ice/ice_ptp.c | 8 ++++++++
>  1 file changed, 8 insertions(+)

Tested-by: Alexander Nowlin <[email protected]>