Re: [PATCH] btree: Add custom allocator interface.

Stuart Longland <[email protected]> Mon, 8 Feb 2016 14:26:29 +1000

Newsgroups	org.ozlabs.lists.ccan
Message-ID	<[email protected]>

On 08/02/16 12:17, David Gibson wrote:
>> +static void* default_malloc(const struct btree_allocator* alloc, size_t size);
> Existing style in this function suggests "void *foo" rather than
> "void* foo".

Ahh, call it habit, I'm used to having the "pointer" bit with the type
(as to me; "pointer to void" is a distinct type from "void").  Caught
myself doing it elsewhere but missed it here, I'll fix it.

> [snip]
>> > +/* Default allocator implementation */
>> > +const struct btree_allocator BTREE_DEFAULT_ALLOCATOR = {
> Use of all-caps for a non-macro is a bit unexpected.
> 

Good point.  I guess I wanted to visually differentiate a constant from
other member types.

Regards,
-- 
Stuart Longland (aka Redhatter, VK4MSL)

I haven't lost my mind...
  ...it's backed up on a tape somewhere.

_______________________________________________
ccan mailing list
[email protected]
https://lists.ozlabs.org/listinfo/ccan

signature.asc (application/pgp-signature, 819 B)