Re: [PATCH] strgrp: Fix compile errors in example

David Gibson <[email protected]> Tue, 15 Sep 2015 09:55:36 +1000

Newsgroups	org.ozlabs.lists.ccan
Message-ID	<[email protected]>

On Mon, Sep 14, 2015 at 09:44:42PM +0930, Andrew Jeffery wrote:
> Hi David,
> 
> On Mon, 2015-09-14 at 21:25 +1000, David Gibson wrote:
> > Commit 63f13d6 "strgrp: Tidy up kerneldoc in _info" introduced some
> > compile
> > errors into the example in strgrp/_info.  This fixes them.
> 
> Ah damn :( Apologies for that!
>  
> I was hacking around with `make webpages` to check the rendering and
> clearly forgot to run `make check`. I'll make sure to configure Travis
> CI.

Well, make check is pretty slow since it checks the whole repo.
Running ccanlint individually on the module you're working on is
generally a good idea though.

> Separately, I had tried to post the initial patch to the mailing list
> to get some feedback but `git send-email` was failing to send it, not
> sure why. I figured that as the original patch only really appeared on
> Rusty's radar that posting just the "documentation" fixup for review
> might've lacked context, but clearly I should've done so (and clearly
> it was more than "just" documentation).

TBH, I doubt I would have spotted this breakage on inspection so I
don't know that posting for review would have helped.

> Thanks for cleaning up after me :/

No problem :)

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

_______________________________________________
ccan mailing list
[email protected]
https://lists.ozlabs.org/listinfo/ccan

signature.asc (application/pgp-signature, 819 B)