Re: [PATCH v2 12/13] Makefile: Define CFLAGS_FORCE_C_SOURCE macro

David Gibson <[email protected]> Tue, 27 Sep 2016 15:18:50 +1000

Newsgroups	org.ozlabs.lists.ccan
Message-ID	<[email protected]>

On Thu, Sep 22, 2016 at 09:33:15PM -0600, Kevin Locke wrote:
> This macro holds the C compiler flag(s) to force input files to be
> recognized as C sources regardless of extension.  It is defined to allow
> overriding on the make command line.
> 
> Signed-off-by: Kevin Locke <[email protected]>

So.. this approach works.

But I've been wondering for a while if the weird thing we do of having
the _info files not have a .c extension is a good idea.

I think the underscore enough is probably enough to mark those
special, so things might be less messy if we just called them _info.c.

Rusty, thoughts?

> ---
>  Makefile      | 2 +-
>  Makefile-ccan | 1 +
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/Makefile b/Makefile
> index 127b875..37ff17d 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -64,7 +64,7 @@ summary-fastcheck/%: tools/ccanlint/ccanlint $(OBJFILES)
>  	$(CCANLINT_FAST) -s ccan/$*
>  
>  ccan/%/info: ccan/%/_info config.h
> -	$(CC) $(CCAN_CFLAGS) -I. -o $@ -x c $<
> +	$(CC) $(CCAN_CFLAGS) -I. -o $@ $(CFLAGS_FORCE_C_SOURCE) $<
>  
>  all_info: $(MODS:%=ccan/%/info)
>  
> diff --git a/Makefile-ccan b/Makefile-ccan
> index 5c8dea2..d4a5528 100644
> --- a/Makefile-ccan
> +++ b/Makefile-ccan
> @@ -5,6 +5,7 @@
>  #CCAN_CFLAGS=-g -O3 -Wall -Wstrict-prototypes -Wold-style-definition -Wmissing-prototypes -Wmissing-declarations -Wpointer-arith -Wwrite-strings -Wundef -DCCAN_STR_DEBUG=1
>  CCAN_CFLAGS=-g3 -ggdb -Wall -Wstrict-prototypes -Wold-style-definition -Wmissing-prototypes -Wmissing-declarations -Wpointer-arith -Wwrite-strings -Wundef -DCCAN_STR_DEBUG=1
>  CFLAGS = $(CCAN_CFLAGS) -I. $(DEPGEN)
> +CFLAGS_FORCE_C_SOURCE = -x c
>  
>  MODS := a_star \
>  	aga \

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

_______________________________________________
ccan mailing list
[email protected]
https://lists.ozlabs.org/listinfo/ccan

signature.asc (application/pgp-signature, 819 B)