Re: [PATCH v2 12/13] Makefile: Define CFLAGS_FORCE_C_SOURCE macro

David Gibson <[email protected]> Wed, 28 Sep 2016 12:01:27 +1000

Newsgroups	org.ozlabs.lists.ccan
Message-ID	<20160928020127.GC18880@umbus>

On Tue, Sep 27, 2016 at 03:48:33PM +0930, Paul 'Rusty' Russell wrote:
> David Gibson <[email protected]> writes:
> > On Thu, Sep 22, 2016 at 09:33:15PM -0600, Kevin Locke wrote:
> >> This macro holds the C compiler flag(s) to force input files to be
> >> recognized as C sources regardless of extension.  It is defined to allow
> >> overriding on the make command line.
> >> 
> >> Signed-off-by: Kevin Locke <[email protected]>
> >
> > So.. this approach works.
> >
> > But I've been wondering for a while if the weird thing we do of having
> > the _info files not have a .c extension is a good idea.
> >
> > I think the underscore enough is probably enough to mark those
> > special, so things might be less messy if we just called them _info.c.
> >
> > Rusty, thoughts?
> 
> _info.c breaks the "compile *.c to get the module" rule, though.

Which is already broken by modules which have a non-trivial Makefile
fragment (like ntdb).

> _info is for both machines and humans, so it's a border case, but I
> think it comes down on "make the machine work harder".

Ok, let's keep this patch as is for the time being then.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

_______________________________________________
ccan mailing list
[email protected]
https://lists.ozlabs.org/listinfo/ccan

signature.asc (application/pgp-signature, 819 B)