Re: [PATCH v2 06/13] configurator: Print test source without cat

On Tue, 2016-09-27 at 15:06 +1000, David Gibson wrote:
> On Thu, Sep 22, 2016 at 09:33:09PM -0600, Kevin Locke wrote:
>> Windows does not provide cat.  Instead, copy the test source to stdout
>> using the file stream to which it was written.
>> 
>> Changes since v1:
>> - Create fwrite_noeintr to avoid EINTR in fwrite without writing any
>>   data.
>> - Handle short reads from fread.  This can happen with non-conformant
>>   libc or if EINTR occurs after reading some data.
>> - Handle short writes from fwrite.  This can happen with non-conformant
>>   libc or if EINTR occurs after writing some data.
>> 
>> Signed-off-by: Kevin Locke <[email protected]>
> 
> As with patch 2, I'm not sure about the need for fwrite_noeintr().

Agreed.  The v1 patch should be good as-is with just a few line
offsets.  If it gives you any problems, I can post an updated one.

Kevin
_______________________________________________
ccan mailing list
[email protected]
https://lists.ozlabs.org/listinfo/ccan