Re: [PATCH] ccanlint: enhance and streamline "output" testing lines.
David Gibson <[email protected]> Tue, 29 Sep 2015 00:58:32 +1000
| Newsgroups | org.ozlabs.lists.ccan |
|---|---|
| Message-ID | <[email protected]> |
On Tue, Sep 29, 2015 at 12:32:36AM +1000, David Gibson wrote: > On Mon, Sep 28, 2015 at 12:48:03PM +0930, Paul 'Rusty' Russell wrote: > > 1) Require "" around input > > 2) Make them optional around output: if not there, loose match whitespace > > 3) Handle \n in output. > > 4) Document that "Given xxx" is optional. > > Patch looks fine to me. I take that back. With a bit more playing, noticed that if you *don't* put" around the input, it will silently skip the example expected output test. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson _______________________________________________ ccan mailing list [email protected] https://lists.ozlabs.org/listinfo/ccan
signature.asc
(application/pgp-signature, 819 B)
-----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWCVWXAAoJEGw4ysog2bOSimYQAInZBPHlxV6Mf14IBqOh6TCe ejYl0elDcrYOjDmol/EL8rpyF+Xhr8/gADg765skxJXVa+2bsi2pDR353lPlXubT vqTUlRZ9joPEoUNHaCW/p0dS4h48CsGg5rp2EoQ9aW5q+ObrTzkbm2ikJVDCvKLh ySq1mPwDRZSpYvkxBlcwITYlZyoXfcqCvLdaDc2xdFLj7zaj8QUik+bAr04rvRZb S0bX3cb0K7g0d4iPtIHiYBoIAgfvdN3QRP80FuQS+SK87ABiWL2o4nLvHajxQ7hB UwFJ2RPEK1rFGM5JCOB0KX52YecmAPLYzyqEbzFTccO3GcTHIvMfBMjcwymN7Kic kqUWBJzsO07VpWA4LT5SQehqYL7jh3R7SwHLdtH5MZajwADx7FeAcq1KfXxjhOqD pcdJpu0WCAHVjhYVt0cTjPCh5oo6H5hhONQkeWFq31PahwAo413PtaTCm54stb1g nH4Pa2VMRzJ7RfxNkXJOO5k2CkYEvRWJGYfTb/XebJaHn2FDCYTNZxQGU8+TdoYM k2s2DNCwDki+8BRPAxndmr7bIlNKxvJbL0uKuxFra/e3gcisM5cnF8MktIr1yUvU DXNvE4cYVB5+MOKT55vmHOTHXfATnPb2lSH9tuCVGhi/CeBgTe/nTPhRsaG6T8HF zBqDxY/O/bu42S6v+o4g =jh4V -----END PGP SIGNATURE-----