Re: [ccan] New to ccan

--===============1203476716209864755==
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="o5TzMHKeQOUdPdVL"
Content-Disposition: inline


--o5TzMHKeQOUdPdVL
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Jun 01, 2024 at 07:23:07PM +1000, David Gibson wrote:
> On Wed, May 08, 2024 at 04:34:10PM -0700, Ashok Raj wrote:
> > On Tue, May 07, 2024 at 12:54:07PM -0700, Ashok Raj wrote:
> > > Hi
> > >=20
> > > I'm new to ccan. I'm trying to use just part of the project (just one
> > > module) in another tool.=20
> > >=20
> > > I didn't catch the exact method to replicate a single module.
>=20
> As I recall, we talked about this a bit, but never did come up with a
> great method.
>=20
> > So I went past this step and able to include it in my project.
> >=20
> > But I see the following warning
> >=20
> > [16/247] Compiling C object libccan.a.p/ccan_bitmap_bitmap.c.o
> > In file included from ../ccan/bitmap/bitmap.c:5:
> > ../ccan/bitmap/bitmap.h: In function bitmap_set_bit:
> > ../ccan/bitmap/bitmap.h:61:43: warning: declaration of bitmap shadows a=
 global declaration [-Wshadow]
> >    61 | static inline void bitmap_set_bit(bitmap *bitmap, unsigned long=
 n)
> >       |                                   ~~~~~~~~^~~~~~
> > ../ccan/bitmap/bitmap.h:26:3: note: shadowed declaration is here
> >    26 | } bitmap;
> >       |   ^~~~~~
> >=20
> >=20
> > If I were to change the parameter name to _bitmap and in all usages the
> > warning disappears. Weird the definition its pointing to is this
> > typedewf
>=20
> Huh.  Looks like the code is relying on types and variables/parameters
> being in different namespaces, but that warning doesn't like that.  I
> guess we must not have had the relevant warning enabled before.
>=20
> I made a fix, but it's been so long since I pushed things to the ccan
> repo, I've forgotten how and will have to figure it out again.

Ok, I figured it out.  Fix is now pushed to https://github.com/rustyrussell=
/ccan.git

--=20
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

--o5TzMHKeQOUdPdVL
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmZdPvEACgkQzQJF27ox
2GcCrA/8C0A4Bsnz7WcbTlOXxicVe2wVO1lhceqChKA7e2btNMWTr8srjR+B82P9
65qJ/d3K9wvxBhtOQMdUTu+rPdf4WqkUdaawY/VfcXeKebZANcvTDk67pumNME+U
J1NjIUZi2qs5QpDMuzutD10h/sE9URbofUQY8dGSUU5T4n9Q37GTpYo+QMDNdyMB
clPSIRvqYa93sMhYXvAHFiWXLV0v0fxq6vjt4h/34BJqJYzD8YKJnyHtk+l96pvE
AEaemGrO1xm/JFRx9UCGOVRs2AsXcIHHpzg/HMjMY1GHwgVCy/8IC2LGbU2f1BfA
R3K5819p6UMAkVO0tKxIX98WTmQOTpOyHJGUq7w8wXOYuhVmtyqHURtAdLddRRPH
bInBe5ofEE6x0CVHgUZcpTO8Qn1bg1RrdkTHvsqkHitAZ2fa9reIU6yt0IoNMcTH
58M+tqAPrjsZE+J2sNLk/tblOqFwON8V63pg0NQF99tDirMilactHzquuTRKO3+/
ZOxU2juIFxStAUfbC08dJoVNQwyvhJrQ0yKmxFLxr8SYTsQGp9MgNcYB1VfhnYow
8N+IYK9S9ScL4FdarbSFe1hLyGOE6Y0Pp51Crlf3NVnxwy3qh5kDjIMmGJFuxhuZ
fwIifdvUTEhfdeEuJLbp5Ij6dby9GXTgtcgSPD30JaStoUYUY/E=
=uvqI
-----END PGP SIGNATURE-----

--o5TzMHKeQOUdPdVL--

--===============1203476716209864755==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
ccan mailing list
[email protected]
https://lists.ozlabs.org/listinfo/ccan

--===============1203476716209864755==--