Re: [PATCH v3 2/7] dt-bindings: serial: 8250: aspeed: add aspeed,vuart-over-pci bool prop
Grégoire Layet <[email protected]> Wed, 24 Jun 2026 14:48:02 +0200
| Newsgroups | org.ozlabs.lists.linux-aspeed,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel,org.kernel.vger.linux-serial |
|---|---|
| Message-ID | <CAFi2wKbKr8FMcJeGWA5e1UZUTh2=LwYNkLEj6exd2as7=AcvVQ@mail.gmail.com> |
Hi Krzysztof, > What does that mean? How UART can be accessible over PCI bus? It's a Virtual UART. Internally, it's two FIFOs accessible via 8250-compatible register sets on both ends. There is 4 Virtuals UARTs on the LPC bus of the AST2600 and 2 of them are bridged over the PCI bus. So, from the host, you can access the 8250 register set on the PCI bus. > > + aspeed,vuart-over-pci: > > + type: boolean > > + default: false > > There is no such syntax. Please do not introduce own style. Instead, > look at other files how this is done. Ack. I will remove 'default: false' for the v4. > > + description: | > > Do not need '|' unless you need to preserve formatting. Acknowledged Best regards, Grégoire