Re: [PATCH] clk: aspeed: ast2700: select AUXILIARY_BUS

Andrew Jeffery <[email protected]> Wed, 22 Jul 2026 15:43:07 +0930
Newsgroups org.ozlabs.lists.linux-aspeed,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-clk,org.kernel.vger.linux-kernel
Message-ID <92837fb6c6dc9d25de5cb91d338cb8de9544c0ce.camel@codeconstruct.com.au>
On Sun, 2026-07-12 at 18:03 +0200, Karl Mehltretter wrote:
> The AST2700 clock driver also exposes the SoC reset controller: it hands
> its register base to a reset auxiliary device via
> devm_auxiliary_device_create(), which the separate ASPEED reset driver
> (RESET_ASPEED) then binds to. That create call needs the auxiliary bus
> core (AUXILIARY_BUS), not the reset driver itself, but COMMON_CLK_AST2700
> does not select AUXILIARY_BUS.
>=20
> It builds today only because RESET_ASPEED selects AUXILIARY_BUS and is
> normally enabled alongside the clock driver. On a randconfig with
> COMMON_CLK_AST2700=3Dy and RESET_ASPEED=3Dn, nothing pulls the auxiliary =
bus
> in and the kernel fails to link:
>=20
> =C2=A0 ld: drivers/clk/aspeed/clk-ast2700.o: in function `ast2700_soc_clk=
_probe':
> =C2=A0 clk-ast2700.c:(.text+0x147c): undefined reference to `__devm_auxil=
iary_device_create'
>=20
> Select AUXILIARY_BUS directly, as other clock drivers that create
> auxiliary devices do, so it builds regardless of the reset driver.
>=20
> Fixes: fdc1eb624ddc ("clk: aspeed: add AST2700 clock driver")
> Signed-off-by: Karl Mehltretter <[email protected]>

Reviewed-by: Andrew Jeffery <[email protected]>