Re: [PATCH v8 2/2] ARM: dts: aspeed: ventura2: Add Meta ventura2 BMC

Hi Andrew,

Thanks for taking the time to review this.
On Wed, Jul 22, 2026 at 7:46=E2=80=AFPM Andrew Jeffery
<[email protected]> wrote:
>
> On Mon, 2026-06-15 at 10:46 +0800, Kyle Hsieh wrote:
> > Ventura2 is a Rack Management Controller. It is a modular
> > device designed to manage liquid cooling systems and monitor hardware
> > states within an IT rack. The system uses an AST2600 BMC for management=
.
> >
> > RMCv2 serves several critical roles:
> > - Detects liquid leakage at both tray and rack levels.
> > - Communicates with and controls liquid cooling equipment.
> > - Manages leakage events and executes system recovery protocols.
> >
> > Key hardware features include:
> > - An extensive I2C and IO expander topology to support comprehensive
> >   sensor monitoring and backward compatibility with legacy trays.
> > - MCTP over I2C support for asynchronous device communications.
> > - A dual-flash design for BMC firmware redundancy.
> >
> > Signed-off-by: Kyle Hsieh <[email protected]>
> > ---
> >  arch/arm/boot/dts/aspeed/Makefile                  |    1 +
> >  .../dts/aspeed/aspeed-bmc-facebook-ventura2.dts    | 2903 ++++++++++++=
++++++++
> >  2 files changed, 2904 insertions(+)
>
> We now have scripts/dtc/dt-check-style. Running it over the dts with '-
> -mode relaxed' yields 49 instances of 'mixed-indent-chars' - these must
> be fixed. Further, can you please look at the output with '--mode
> strict', address all the warnings that are reasonable, and then discuss
> what's left?
I have fixed all 49 instances of the 'mixed-indent-chars' formatting issues=
.
I also ran it with '--mode strict' and addressed the formatting
warnings accordingly.
>
> Otherwise, there are still some concerns reported against the bindings:
>
>    $ make CHECK_DTBS=3Dy aspeed/aspeed-bmc-facebook-ventura2.dtb W=3D1
>    ...
>      DTC [C] arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-ventura2.dtb
>    arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-ventura2.dtb: /ahb/apb/lp=
c@1e789000/lhc@a0: failed to match any schema with compatible: ['aspeed,ast=
2600-lhc']
>    /home/andrew/src/kernel.org/linux/origin/build.arm.aspeed_g5/arch/arm/=
boot/dts/aspeed/aspeed-bmc-facebook-ventura2.dtb: fan-controller@20 (maxim,=
max31790): 'channel@2', 'channel@5' do not match any of the regexes: '^fan@=
[0-9]+$', '^pinctrl-[0-9]+$'
>            from schema $id: http://devicetree.org/schemas/hwmon/maxim,max=
31790.yaml
>    /home/andrew/src/kernel.org/linux/origin/build.arm.aspeed_g5/arch/arm/=
boot/dts/aspeed/aspeed-bmc-facebook-ventura2.dtb: i2c@400 (aspeed,ast2600-i=
2c-bus): Unevaluated properties are not allowed ('aspeed,hw-timeout-ms' was=
 unexpected)
>            from schema $id: http://devicetree.org/schemas/i2c/aspeed,i2c.=
yaml
>    /home/andrew/src/kernel.org/linux/origin/build.arm.aspeed_g5/arch/arm/=
boot/dts/aspeed/aspeed-bmc-facebook-ventura2.dtb: adc@48 (ti,ads1015): '#ad=
dress-cells' is a required property
>            from schema $id: http://devicetree.org/schemas/iio/adc/ti,ads1=
015.yaml
>    /home/andrew/src/kernel.org/linux/origin/build.arm.aspeed_g5/arch/arm/=
boot/dts/aspeed/aspeed-bmc-facebook-ventura2.dtb: adc@48 (ti,ads1015): '#si=
ze-cells' is a required property
>            from schema $id: http://devicetree.org/schemas/iio/adc/ti,ads1=
015.yaml
>    arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-ventura2.dtb: /ahb/apb/bu=
s@1e78a000/i2c@580/power-monitor@69: failed to match any schema with compat=
ible: ['pmbus']
>    arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-ventura2.dtb: /ahb/apb/bu=
s@1e7a0000/syscon@0: failed to match any schema with compatible: ['aspeed,a=
st2600-i3c-global', 'syscon']
>
> Can you please tidy these up?
The board-specific bindings have been fixed:
- Removed the invalid `channel@X` subnodes from the `maxim,max31790`
fan controller.
- Dropped the deprecated `aspeed,hw-timeout-ms` property from the I2C bus.
- Removed the incomplete `ti,ads1015` ADC and generic `pmbus` power
monitor nodes to fully comply with upstream schemas.

However, the warnings for `aspeed,ast2600-lhc` and
`aspeed,ast2600-i3c-global` still remain.
Since these nodes are inherited directly from the SoC level
(`aspeed-g6.dtsi`), it seems their YAML bindings are not yet merged
upstream.

>
> Thanks,
>
> Andrew

Thanks,
Kyle