Re: [PATCH v4 2/2] ARM: dts: aspeed: Add NVIDIA VR-NVL BMC

Rob Herring <[email protected]> Wed, 29 Jul 2026 08:17:40 -0500

Newsgroups	org.ozlabs.lists.linux-aspeed,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel,org.ozlabs.lists.openbmc
Message-ID	<CAL_JsqKx4OEM-asdvs1wUiP3FFObzJHZtNTtqiwtcRhJ5CPRyQ@mail.gmail.com>

On Wed, Jul 29, 2026 at 1:06=E2=80=AFAM Jacky Huang <[email protected]>=
 wrote:
>
> Hi Rob,
>
> Thank you very much for the review.
>
> On Tue, Jul 28, 2026 at 09:39:52AM -0500, Rob Herring wrote:
> > > +                           cp2112g: device@2 {
> >
> > This and other devices should have a compatible string and associated
> > schema. The hub probably should too.
>
> Will fix in v5.
>
> > > +   flash@0 {
> >
> > Needs a compatible.
>
> The flash@0 node augments the corresponding node defined in
> aspeed-g6.dtsi, which already carries compatible =3D "jedec,spi-nor",
> so the compatible is inherited. The same applies to the flash@0
> under &spi2.

Is the flash part of the SoC package? A board level component
shouldn't be in the SoC .dtsi file. If there's some components that
all/most boards happen to use, then those should be a common board
.dtsi file.

Rob