Re: [PATCH v4 2/2] ARM: dts: aspeed: Add NVIDIA VR-NVL BMC
Jacky Huang <[email protected]> Wed, 29 Jul 2026 17:40:10 +0900
| Newsgroups | org.ozlabs.lists.linux-aspeed,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel,org.ozlabs.lists.openbmc |
|---|---|
| Message-ID | <[email protected]> |
Hi Krzysztof,
On Wed, Jul 29, 2026 at 08:16:52AM +0200, Krzysztof Kozlowski wrote:
> Why are you extending existing nodes that way instead of phandle/label?
> You write confusing code, so that's why you have such comments.
Thank you for pointing this out. I agree that the current form is unclear.
For v5, I plan to add source labels to the existing flash nodes in
aspeed-g6.dtsi:
fmc: spi@1e620000 {
fmc_flash0: flash@0 {
...
};
};
spi2: spi@1e631000 {
spi2_flash0: flash@0 {
...
};
};
The board DTS will then reference them directly:
&fmc_flash0 {
...
};
&spi2_flash0 {
...
};
This should make the references to the existing nodes explicit.
Best,
Jacky