Re: [PATCH v5 6/6] ARM: dts: aspeed: g6: add aspeed,vuart-over-pci prop to vuart3 and 4
Tan Siewert <[email protected]>
| Newsgroups | org.ozlabs.lists.linux-aspeed,dev.linux.lists.mfd,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel,org.kernel.vger.linux-serial |
|---|---|
| Message-ID | <178609182924.193353.1528505361399129387.b4-review@b4> |
> The VUART 3 and 4 are VUART over PCI. > Set this flag to indicate this information. > Also set the syscon phandle. > > Signed-off-by: Grégoire Layet <[email protected]> > > diff --git a/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi b/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi > index 7c02633f2bd6..fbd7ab6332a1 100644 > --- a/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi > +++ b/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi > @@ -722,7 +722,9 @@ vuart3: serial@1e787800 { > reg-shift = <2>; > interrupts = <GIC_SPI 180 IRQ_TYPE_LEVEL_HIGH>; > clocks = <&syscon ASPEED_CLK_APB2>; > + aspeed,scu-syscon = <&syscon>; > no-loopback-test; > + aspeed,vuart-over-pci; > status = "disabled"; > }; dt-style check fails with: arch/arm/boot/dts/aspeed/aspeed-g6.dtsi:723: [property-order] property 'interrupts' out of canonical order (should sort before 'reg-shift') arch/arm/boot/dts/aspeed/aspeed-g6.dtsi:724: [property-order] property 'clocks' out of canonical order (should sort before 'interrupts') arch/arm/boot/dts/aspeed/aspeed-g6.dtsi:726: [property-order] property 'no-loopback-test' out of canonical order (should sort before 'aspeed,scu-syscon') arch/arm/boot/dts/aspeed/aspeed-g6.dtsi:728: [required-blank-lines] "status" must be preceded by a blank line > > @@ -742,7 +744,9 @@ vuart4: serial@1e788800 { > reg-shift = <2>; > interrupts = <GIC_SPI 181 IRQ_TYPE_LEVEL_HIGH>; > clocks = <&syscon ASPEED_CLK_APB2>; > + aspeed,scu-syscon = <&syscon>; > no-loopback-test; > + aspeed,vuart-over-pci; > status = "disabled"; > }; > Same here: arch/arm/boot/dts/aspeed/aspeed-g6.dtsi:742: [line-length] line exceeds 80 columns (92) arch/arm/boot/dts/aspeed/aspeed-g6.dtsi:745: [property-order] property 'interrupts' out of canonical order (should sort before 'reg-shift') arch/arm/boot/dts/aspeed/aspeed-g6.dtsi:746: [property-order] property 'clocks' out of canonical order (should sort before 'interrupts') arch/arm/boot/dts/aspeed/aspeed-g6.dtsi:748: [property-order] property 'no-loopback-test' out of canonical order (should sort before 'aspeed,scu-syscon') arch/arm/boot/dts/aspeed/aspeed-g6.dtsi:750: [required-blank-lines] "status" must be preceded by a blank line Tan -- Tan Siewert <[email protected]>