Re: [PATCH 2/2] erofs-utils: libzstd: fix undefined behavior shift in setdictsize

Gao Xiang <[email protected]>
Newsgroups org.ozlabs.lists.linux-erofs
Message-ID <[email protected]>

On 2026/4/20 10:50, Nithurshen wrote:
> Hi Xiang,
> 
> I do agree that `pclustersize_max` is always greater than 0 and
> `ondisk_extradevs` is at max 65535.
> 
> My intent was to look at these functions as independent blocks.
> Even though the current upstream callers provide safe inputs, I
> wanted to make them robust against any undefined behavior in case
> they are reused in the future.

They won't be reused in any case like this.

> 
> Thanks,
> Nithurshen
> 
> Regards,
> Nithurshen
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.