Re: [PATCH v1 1/1] test: fs: Use shared generate_file from utils

Hello,

On 5/11/26 10:58, Aristo Chen wrote:
> test_fs/test_erofs.py and test_fs/test_squashfs/sqfs_common.py both
> defined a generate_file() helper that writes a file of a given size
> filled with 'x'. The two functions were functionally identical and
> differed only in parameter names and docstrings.
> 
> Move the helper into the existing test/py/utils.py module, which is
> the established home for generic test utilities (md5sum_file,
> PersistentRandomFile, attempt_to_open_file). Update both call sites
> to use it.
> 
> Signed-off-by: Aristo Chen <[email protected]>
> ---
>   test/py/tests/test_fs/test_erofs.py           | 16 ++++----------
>   .../test_fs/test_squashfs/sqfs_common.py      | 22 +++++--------------
>   test/py/utils.py                              | 13 +++++++++++
>   3 files changed, 22 insertions(+), 29 deletions(-)
(...)

Thanks for the patch!

Reviewed-by: [email protected]
-- 
Best regards,
João Marcos Costa