Re: [PATCH 9/9] test: test_erofs: adjust expected ls output
Simon Glass <[email protected]>
| Newsgroups | org.ozlabs.lists.linux-erofs,org.u-boot-project.lists.u-boot |
|---|---|
| Message-ID | <CAFLszTgsRzmqmfP2Xa3bOqqEBeL+riN50vMgZJT2LXcebmwt6w@mail.gmail.com> |
Hi Heinrich, On 2026-05-18T05:57:19, Heinrich Schuchardt <[email protected]> wrote: > test: test_erofs: adjust expected ls output > > With the addition of the date field the space between columns in the ls > output has been reduced. Reflect this in the expected lines of the erofs > test. > > Signed-off-by: Heinrich Schuchardt <[email protected]> > > test/py/tests/test_fs/test_erofs.py | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > diff --git a/test/py/tests/test_fs/test_erofs.py b/test/py/tests/test_fs/test_erofs.py > @@ -73,8 +73,8 @@ def erofs_ls_at_root(ubman): > - expected_lines = ['./', '../', '4096 f4096', '7812 f7812', 'subdir/', > - '<SYM> symdir', '<SYM> symfile', '4 file(s), 3 dir(s)'] > + expected_lines = ['./', '../', '4096 f4096', '7812 f7812', 'subdir/', > + '<SYM> symdir', '<SYM> symfile', '4 file(s), 3 dir(s)'] Patches 7 and 8 took the flexible-regex approach (' .*' / ' +') so the assertion does not need touching again next time the column layout shifts. Since EROFS goes through fs_ls_generic() too, please do the same here rather than hard-coding the single-space layout. Regards, Simon