Re: [PATCH] soc: fsl: dpio: Remove redundant dev_err()
"Christophe Leroy (CS GROUP)" <[email protected]>
| Newsgroups | org.ozlabs.lists.linuxppc-dev,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
Hi Ioana,
Le 23/07/2026 à 04:47, Pan Chuang a écrit :
> Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
> devm_request_*_irq()"), devm_request_irq() automatically logs
> detailed error messages on failure. Remove the now-redundant
> driver-specific dev_err() calls.
>
> Signed-off-by: Pan Chuang <[email protected]>
I plan to take this patch for v7.3, do you agree with this change ?
Thanks
Christophe
> ---
> drivers/soc/fsl/dpio/dpio-driver.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/soc/fsl/dpio/dpio-driver.c b/drivers/soc/fsl/dpio/dpio-driver.c
> index 9e3fddd8f5a9..d5198ffc4455 100644
> --- a/drivers/soc/fsl/dpio/dpio-driver.c
> +++ b/drivers/soc/fsl/dpio/dpio-driver.c
> @@ -102,12 +102,8 @@ static int register_dpio_irq_handlers(struct fsl_mc_device *dpio_dev, int cpu)
> 0,
> dev_name(&dpio_dev->dev),
> &dpio_dev->dev);
> - if (error < 0) {
> - dev_err(&dpio_dev->dev,
> - "devm_request_irq() failed: %d\n",
> - error);
> + if (error < 0)
> return error;
> - }
>
> /* set the affinity hint */
> if (irq_set_affinity_hint(irq->virq, cpumask_of(cpu)))