Re: [PATCH v2 1/2] soc: fsl: dpio: Use scope-based resource management in dpaa2_io_store_create()

Markus Elfring <[email protected]> Wed, 29 Jul 2026 10:24:32 +0200

Newsgroups	org.ozlabs.lists.linuxppc-dev,org.infradead.lists.linux-arm-kernel,org.kernel.vger.kernel-janitors,org.kernel.vger.linux-kernel
Message-ID	<[email protected]>

…
>> +++ b/drivers/soc/fsl/dpio/dpio-service.c
…
>> -	size = max_frames * sizeof(struct dpaa2_dq) + 64;
>> -	ret->alloced_addr = kzalloc(size, GFP_KERNEL);
>> -	if (!ret->alloced_addr) {
>> -		kfree(ret);
>> +	ret->alloced_addr = kzalloc(max_frames * sizeof(struct dpaa2_dq) + 64, GFP_KERNEL);
>> +	if (!ret->alloced_addr)
>>  		return NULL;
> 
> Why convert the ret allocation but not the ret->alloced_addr allocation?
I suggest to reconsider the suggested influence of the attribute “__free(kfree)”
once more also according to data structure members.

Regards,
Markus