Re: [PATCH 0/2] powerpc/sstep: Fix compilation on 32-bit PowerPC
"Christophe Leroy (CS GROUP)" <[email protected]> Thu, 30 Jul 2026 07:51:40 +0200
| Newsgroups | org.ozlabs.lists.linuxppc-dev,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
Le 29/07/2026 à 22:49, Link Mauve a écrit : > Two local variables were only set but never read on 32-bit PowerPC, > which causes an error during compilation. Are those errors new ? This series and the one from yesterday on ppc64, I have the feeling that the code is not new. Has anything changed in the building flags or does this pops up with recent versions of GCC ? If it is the case it is worth saying it in the commit messages in order to clarify the reason for the fix. > > This series first makes the 64-bit guards consistent by converting all > uses of CONFIG_PPC64 to use __powerpc64__ instead, and then guard the > two variables rc and suffix behind __powerpc64__ checks. > > Link Mauve (2): > powerpc/sstep: Consistently use one define to check arch bit width > powerpc/sstep: Don’t define variables we won’t be using > > arch/powerpc/lib/sstep.c | 26 ++++++++++++++++---------- > 1 file changed, 16 insertions(+), 10 deletions(-) > > > base-commit: 78bc8af4affb9a732504eb22eeac7d1e50883853