Re: [PATCH v2 0/2] powerpc/sstep: Fix compilation on 32-bit PowerPC

Le 30/07/2026 à 08:50, Link Mauve a écrit :
> Two local variables were only set but never read on 32-bit PowerPC,
> which causes an error during compilation with W=1.
> 
> This series first makes the 64-bit guards consistent by converting all
> uses of __powerpc64__ to use CONFIG_PPC64 instead, and then guard the
> two variables rc and suffix behind CONFIG_PPC64 checks.
> 

For the two patches,

Reviewed-by: Christophe Leroy (CS GROUP) <[email protected]>

> Link Mauve (2):
>    powerpc/sstep: Consistently use one define to check arch bit width
>    powerpc/sstep: Don’t define variables we won’t be using
> 
>   arch/powerpc/lib/sstep.c | 111 ++++++++++++++++++++-------------------
>   1 file changed, 58 insertions(+), 53 deletions(-)
> 
> Changes since v1:
> - Link to v1:
>    https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.kernel.org%2Flinuxppc-dev%2Famrpdv0g__ELifId%40desktop%2FT%2F&data=05%7C02%7Cchristophe.leroy%40csgroup.eu%7C69210bfbc364426c4ce108deee06d0f2%7C8b87af7d86474dc78df45f69a2011bb5%7C0%7C0%7C639209910199709261%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=%2B%2BdoT%2FTkFxUUy63ED%2B5Kb5dfCSI8hQpjWGfpndI%2Fn0c%3D&reserved=0
> - Switch from __powerpc64__ to CONFIG_PPC64, as it is the preferred
>    check.
> - Document that the build error was only occurring with W=1.
> - Declare both variables on the same line.
> 
> base-commit: 78bc8af4affb9a732504eb22eeac7d1e50883853