Re: [PATCH 1/4] powerpc/pseries: Limit PVR list to 16 entries for CAS negotiation

Nikhil Kumar Singh <[email protected]> Mon, 3 Aug 2026 08:52:24 +0530
Newsgroups org.ozlabs.lists.linuxppc-dev
Message-ID <[email protected]>

On 29/07/26 20:24, Mahesh Salgaonkar wrote:

> +	if ((ARRAY_SIZE(ibm_architecture_vec_template.pvrs) > 16) &&
> +	    (PVR_VER(mfspr(SPRN_PVR)) <= PVR_POWER11))
> +		start_index = ARRAY_SIZE(ibm_architecture_vec_template.pvrs) - 16;



Hi Mahesh,

The literal 16 appears twice. Please define a named macro,
e.g.: #define CAS_MAX_PVR_ENTRIES 16

Thanks,
~ Nikhil