Re: [PATCH v4] powerpc/pseries/iommu: Add TCEs for 16GB pages when RAM is pre-mapped
Ritesh Harjani (IBM) <[email protected]>
| Newsgroups | org.ozlabs.lists.linuxppc-dev,org.kernel.vger.stable |
|---|---|
| Message-ID | <[email protected]> |
Gaurav Batra <[email protected]> writes: > Hello Ritesh, > <...> > As you correctly pointed out in the enable_ddw() code, this could lead > to EEH if > pmemory is assigned to the same power-of-2 chunk as (RAM + 16GB pages). > > It would be better to set device bus_dma_limit to pseries_ddw_max_ram > and *not* > > max_ram_pages, which in this case is the size of the DDW. > > I will fix this in my next version of the patch. Sure, thanks for veryfing that claim. > Please let me know if you have any other concerns. I will incorporate all those changes in the next version of the patch. > Nothing else. Otherwise, it looks good. > Thanks a lot for spending time and checking this code in deep. No issues. Thanks for fixing it! -ritesh