Re: [PATCH v2] scsi: core: Drop Scsi_Host.default_lock

On 8/6/26 4:39 AM, John Garry wrote:
 > Getting the address of embedded host_lock structure just requires adding
 > a fixed offset value to the shost pointer. However, getting the value of
 > the host_lock pointer requires loading from a fixed offset to the shost
 > pointer. The latter should be very slightly slower, which is relevant as
 > this lock is used a lot throughout the core code and drivers.

Hmm ... SCSI drivers for which performance matters shouldn't use the 
SCSI host lock in their hot path.

 > @Bart, Can you kindly build test this? s390 and sh were causing some 
build
 > issues for me. Thanks

This patch passes my build tests, but an update for the references to
default_lock in the Documentation/ directory is missing.

Otherwise this patch looks good to me. So with or without the
Documentation/ update, feel free to add:

Reviewed-by: Bart Van Assche <[email protected]>