RE: [PATCH 1/2] dt-bindings: mmc: sdhci-of-aspeed : Add ast2700 support

> Subject: Re: [PATCH 1/2] dt-bindings: mmc: sdhci-of-aspeed : Add ast2700
> support
> 
> On Fri, Mar 13, 2026 at 01:27:56PM +0800, Ryan Chen wrote:
> > Add the "aspeed,ast2700-sd-controller" compatible. The ast2700 sdhci
> > controller requires an reset, so make the "resets" property mandatory
> > for this compatible to reflect the hardware requirement.
> 
> Subject - there is never space before ':'
Will update
dt-bindings: mmc: sdhci-of-aspeed: Add ast2700 support
> 
> >
> > Signed-off-by: Ryan Chen <[email protected]>
> > ---
> >  Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml | 16
> > ++++++++++++++++
> >  1 file changed, 16 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml
> > b/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml
> > index d24950ccea95..a2ff9a94db13 100644
> > --- a/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml
> > +++ b/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml
> > @@ -26,6 +26,7 @@ properties:
> >        - aspeed,ast2400-sd-controller
> >        - aspeed,ast2500-sd-controller
> >        - aspeed,ast2600-sd-controller
> > +      - aspeed,ast2700-sd-controller
> 
> Missing blank lines everywhere in your patchset.
Will add blank lines.
> 
> >    reg:
> >      maxItems: 1
> >      description: Common configuration registers @@ -37,6 +38,20 @@
> > properties:
> >    clocks:
> >      maxItems: 1
> >      description: The SD/SDIO controller clock gate
> 
> Blank line
Will add blank lines.
> 
> > +  resets:
> > +    maxItems: 1
> 
> Blank line, just open any other bindings. If this is because you used LLM, then
> obviously NAK, because we should not waste time to review unsupervised poor
> quality LLM output. It is your task to review it, not ours.
Will add blank lines.

When I submit, I did checkpatch.pl and also 
DT_SCHEMA_FILES=Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml
make dt_binding_check W=1 didn’t see error, I will review it again. 

Thanks your review.