Re: [PATCH v2 1/2] mmc: dt-bindings: sdhci-of-aspeed: Add AST2700 fallback compatibles

Krzysztof Kozlowski <[email protected]>
Newsgroups org.ozlabs.lists.openbmc,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel,org.kernel.vger.linux-mmc,org.ozlabs.lists.linux-aspeed
Message-ID <[email protected]> 
On 20/03/2026 09:46, Ryan Chen wrote:
> Hello Krzysztof,
> I review https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/example-schema.yaml?h=v7.0-rc1
> I will do following modify
> -    enum:
> -      - aspeed,ast2400-sd-controller
> -      - aspeed,ast2500-sd-controller
> -      - aspeed,ast2600-sd-controller
> +    oneOf:
> +      - items:

Don't add items here. Was it in original code? No.


> +          - enum:
> +              - aspeed,ast2400-sd-controller
> +              - aspeed,ast2500-sd-controller
> +              - aspeed,ast2600-sd-controller
> +      - items:
> +          - const: aspeed,ast2700-sd-controller
> +          - const: aspeed,ast2600-sd-controller
> +
> Thanks the review. 


Best regards,
Krzysztof
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.