Re: [PATCH] iio: adc: npcm: fix unbalanced clk_disable_unprepare()

Andy Shevchenko <[email protected]>
Newsgroups org.ozlabs.lists.openbmc,org.kernel.vger.linux-iio,org.kernel.vger.linux-kernel
Organization Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo
Message-ID <[email protected]>
On Sat, Apr 11, 2026 at 01:35:17PM +0100, David Carlier wrote:

...

>  	ret = devm_request_irq(&pdev->dev, irq, npcm_adc_isr, 0,
>  			       "NPCM_ADC", indio_dev);
>  	if (ret < 0) {

>  		dev_err(dev, "failed requesting interrupt\n");

Also consider killing this message as it dups what IRQ core prints already.

> -		goto err_disable_clk;
> +		return ret;
>  	}

-- 
With Best Regards,
Andy Shevchenko
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.