RE: [PATCH 1/4] pinctrl: realtek: Enable compile testing

Yu-Chun Lin [林祐君] <[email protected]>
Newsgroups org.ozlabs.lists.openbmc,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-gpio,org.kernel.vger.linux-kernel,org.ozlabs.lists.linux-aspeed
Message-ID <[email protected]>
> Enable compile testing for Realtek pin controller drivers for increased build
> and static checkers coverage.  PINCTRL_RTD uses
> pinconf_generic_dt_node_to_map(), thus needs OF.
> 
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
>  drivers/pinctrl/Makefile        |  2 +-
>  drivers/pinctrl/realtek/Kconfig | 12 ++++++------
>  2 files changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/pinctrl/Makefile b/drivers/pinctrl/Makefile index
> 9d33fa28a096..b054cfb99348 100644
> --- a/drivers/pinctrl/Makefile
> +++ b/drivers/pinctrl/Makefile
> @@ -82,7 +82,7 @@ obj-y                         += nuvoton/
>  obj-y                          += nxp/
>  obj-$(CONFIG_PINCTRL_PXA)      += pxa/
>  obj-y                          += qcom/
> -obj-$(CONFIG_ARCH_REALTEK)      += realtek/
> +obj-$(CONFIG_PINCTRL_RTD)      += realtek/
>  obj-$(CONFIG_PINCTRL_RENESAS)  += renesas/
>  obj-$(CONFIG_PINCTRL_SAMSUNG)  += samsung/
>  obj-y                          += sophgo/
> diff --git a/drivers/pinctrl/realtek/Kconfig b/drivers/pinctrl/realtek/Kconfig
> index 054e85db99e7..a156c4ef556e 100644
> --- a/drivers/pinctrl/realtek/Kconfig
> +++ b/drivers/pinctrl/realtek/Kconfig
> @@ -2,8 +2,8 @@
> 
>  config PINCTRL_RTD
>         tristate "Realtek DHC core pin controller driver"
> -       depends on ARCH_REALTEK
> -       default y
> +       depends on ARCH_REALTEK || (COMPILE_TEST && OF)
> +       default ARCH_REALTEK
>         select PINMUX
>         select GENERIC_PINCONF
>         select REGMAP_MMIO
> @@ -11,22 +11,22 @@ config PINCTRL_RTD
>  config PINCTRL_RTD1619B
>         tristate "Realtek DHC 1619B pin controller driver"
>         depends on PINCTRL_RTD
> -       default y
> +       default ARCH_REALTEK
> 
>  config PINCTRL_RTD1319D
>         tristate "Realtek DHC 1319D pin controller driver"
>         depends on PINCTRL_RTD
> -       default y
> +       default ARCH_REALTEK
> 
>  config PINCTRL_RTD1315E
>         tristate "Realtek DHC 1315E pin controller driver"
>         depends on PINCTRL_RTD
> -       default y
> +       default ARCH_REALTEK
> 
>  config PINCTRL_RTD1625
>         tristate "Realtek DHC 1625 pin controller driver"
>         depends on PINCTRL_RTD
> -       default y
> +       default ARCH_REALTEK
>         help
>           This driver enables support for the pin controller on the Realtek
>           RTD1625 SoCs.
> 
> --
> 2.51.0

Reviewed-by: Yu-Chun Lin <[email protected]>
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.