Re: [PATCH linux dev-6.18] eeprom: ee1004: Fix build error

I think this is specifically an OpenBMC kernel problem.
I don't see this error neither in upstream Linux master
https://github.com/torvalds/linux/blob/master/drivers/misc/eeprom/ee1004.c#L341
nor in Linux 6.18
https://github.com/torvalds/linux/blob/v6.18/drivers/misc/eeprom/ee1004.c#L341

On Wed, May 6, 2026 at 6:30 PM Tan Siewert <[email protected]> wrote:
>
> On 5/6/26 8:52 AM, Johannes Truschnigg wrote:
> > On Wed, Apr 29, 2026 at 10:06:47AM +0300, Konstantin Aladyshev wrote:
> >> Currently driver compilation fails because of the undeclared
> >> 'ee1004_groups' variable.
> >> [...]
> >> Fixes: 79d0df36b541 ("eeprom: ee1004: Add nvmem support")
> >
> > Ftr, this patch on (top of 80ec78d (6.18.26)) fixes building linux-aspeed with
> > CONFIG_EEPROM_EE1004=y configured for me, which has otherwise been broken
> > since around October 2025.
> >
> > I recommend merging it :)
> >
>
> It'd be great if the patch could be sent to LKML and let it be
> backported to the upstream 6.18 LTS tree instead of having it only in
> the OpenBMC tree.
>
> To cite the kernel development doc [0]:
> "Submit your patch upstream. It doesn't need to be upstream, but it
> should be on it's way, and not have any unresolved design concerns."
>
> [0]
> https://github.com/openbmc/docs/blob/92b89c6ac71f8b94f67f508102704a1cf38e68cb/kernel-development.md?plain=1#L29
>
>         Tan