Re: [PATCH u-boot v2] ARM: dts: aspeed: Add dts for ASUS Kommando IPMI card
Andrew Jeffery <[email protected]>
| Newsgroups | org.ozlabs.lists.openbmc |
|---|---|
| Message-ID | <943cfc3799373dffe67d5624af5fe10432150857.camel@codeconstruct.com.au> |
Hi Anirudh,
Sorry for the delay :(
On Sat, 2026-03-28 at 14:14 -0500, Anirudh Srinivasan wrote:
> Add dts for Asus Kommando IPMI card, an ast2600 based pcie bmc card.
>
> This version of the DTS doesn't support networking due to u-boot inserting
> mac delays (when it isn't really needed) and needing to misconfigure the
> phy-mode in linux due to it. See discussion here [1] for more details.
>
> Networking can be enabled in this manner currently.
>
> aliases {
> eth0 = &mac2;
> };
>
> &mac2 {
> status = "okay";
> phy-mode = "rgmii-id";
> phy-handle = <ðphy2>;
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_rgmii3_default>;
> };
>
> &mdio {
> status = "okay";
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_mdio3_default>;
> #address-cells = <1>;
> #size-cells = <0>;
>
> ethphy2: ethernet-phy@2 {
> reg = <0>;
> };
> };
>
> &scu {
> mac2-clk-delay = <0 0
> 0 0
> 0 0>;
> };
So something I didn't appreciate in our previous discussion was that
this was a property on the SCU node (I should have looked then).
Checking the implementation, it seems to me like this is the same as
not specifying the property. That corroborates Ender's efforts here:
https://lore.kernel.org/all/[email protected]/
I think we just drop the property and add in the mac nodes, and remove
this note from the commit message?
Possibly some confusion comes from the EVB DTS specifying the property,
and everyone just copied it, then wondered why it was all broken.
Andrew