Re: [PATCH v3 2/3] dt-bindings: pinctrl: Add aspeed,ast2700-soc1-pinctrl
Billy Tsai <[email protected]>
| Newsgroups | org.ozlabs.lists.openbmc,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-clk,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-gpio,org.kernel.vger.linux-kernel,org.ozlabs.lists.linux-aspeed |
|---|---|
| Message-ID | <OSQPR06MB7252FFE3CCFC8767A0CFFC498B002@OSQPR06MB7252.apcprd06.prod.outlook.com> |
> > + properties: > > + function: > > + enum: > > + - ADC0 > > + - ADC1 > It'd be nice if you could use the other enum format I think so that > there's not 700 lines taken up by functions/groups/pins. I considered the inline format, but kept the one-item-per-line style intentionally: with 200+ entries in each enum, any future addition or rename produces a clean single-line diff. The inline format would require re-wrapping the entire list on every change, making those diffs significantly harder to review. > Otherwise, I really don't like this approach but it seems to be standard > on aspeed so whatever. > Acked-by: Conor Dooley <[email protected]> > pw-bot: not-applicable Thank you for the review and the ack. Billy Tsai