RE: [PATCH] spi: aspeed: Replace VLA parameter with flat pointer in calibration helper

Chin-Ting Kuo <[email protected]> Tue, 19 May 2026 12:43:44 +0000

Newsgroups	org.ozlabs.lists.openbmc,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-kernel,org.kernel.vger.linux-spi,org.ozlabs.lists.linux-aspeed
Message-ID	<TYZPR06MB520319C6F48144C8B8470740B2002@TYZPR06MB5203.apcprd06.prod.outlook.com>

Hi Mark,

Thanks for the review.

> -----Original Message-----
> From: Mark Brown <[email protected]>
> Sent: Tuesday, May 19, 2026 7:04 PM
> Subject: Re: [PATCH] spi: aspeed: Replace VLA parameter with flat pointer in
> calibration helper
> 
> On Mon, May 18, 2026 at 05:57:08PM +0800, Chin-Ting Kuo wrote:
> 
> > -			while (k < cols && buf[i][k])
> > +			while (k < cols && buf[i * cols + k])
> 
> This really needs () to make it clear what's going on; the precedence is well
> defined but not everyone is going to know that off the top of their head.

Okay, below change will be added in the next patch version.
while (k < cols && buf[(i * cols) + k])


Chin-Ting