Re: [PATCH u-boot v3 2/2] ARM: dts: aspeed: Add dts for ASUS Kommando IPMI card

On 5/26/26 4:03 AM, Anirudh Srinivasan wrote:
> Add dts for Asus Kommando IPMI card, an ast2600 based pcie bmc card.
> This DT has networking working in rgmii-id mode.
> 
> Signed-off-by: Anirudh Srinivasan <[email protected]>
> ---
>   arch/arm/dts/Makefile                            |  1 +
>   arch/arm/dts/ast2600-asus-kommando-ipmi-card.dts | 92 ++++++++++++++++++++++++
>   2 files changed, 93 insertions(+)
> 
> diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile
> index 5141c3dc3aa025e2f5c9b2bb98216ee5c72cdf70..fa6837be747da4fbe102ac27e60ee3d81e230cb7 100755
> --- a/arch/arm/dts/Makefile
> +++ b/arch/arm/dts/Makefile
> @@ -682,6 +682,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \
>   	ast2500-genesis3.dtb \
>   	ast2500-romulus.dtb \
>   	ast2600-ampere.dtb \
> +	ast2600-asus-kommando-ipmi-card.dtb \
>   	ast2600-bletchley.dtb \
>   	ast2600-dcscm.dtb \
>   	ast2600-evb-ecc.dtb \
> diff --git a/arch/arm/dts/ast2600-asus-kommando-ipmi-card.dts b/arch/arm/dts/ast2600-asus-kommando-ipmi-card.dts
> new file mode 100644
> index 0000000000000000000000000000000000000000..bad3b011bae63c058fecd4790e3243bb0df4b770
> --- /dev/null
> +++ b/arch/arm/dts/ast2600-asus-kommando-ipmi-card.dts
> @@ -0,0 +1,92 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +/dts-v1/;
> +
> +#include "ast2600-u-boot.dtsi"
> +
> +/ {
> +	model = "ASUS Kommando IPMI Card";
> +	compatible = "asus,kommando-ipmi-card", "aspeed,ast2600";
> +
> +	memory {
> +		device_type = "memory";
> +		reg = <0x80000000 0x40000000>;
> +	};
> +
> +	chosen {
> +		stdout-path = &uart5;
> +	};
> +
> +	aliases {
> +		spi0 = &fmc;
> +		eth0 = &mac2;
> +	};
> +
> +	cpus {
> +		cpu@0 {
> +			clock-frequency = <800000000>;
> +		};
> +		cpu@1 {
> +			clock-frequency = <800000000>;
> +		};
> +	};
> +};
> +
> +&fmc {
> +	status = "okay";
> +
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_fmcquad_default>;
> +
> +	flash@0 {
> +		status = "okay";
> +		spi-max-frequency = <50000000>;
> +		spi-tx-bus-width = <4>;
> +		spi-rx-bus-width = <4>;
> +	};

Out of curiosity: which revision of the Kommando IPMI card do you have?
Asking because I have two R1.04s and both fail after a power cycle, but 
only if the SPI was probed by U-Boot before.

I'm still debugging the issue on my side, but based on what I saw with 
my logic analyser it appears that the FMC is in a wrong addressing mode. 
When it reads U-Boot, it's misaligned by 1-byte.
Blipping the /RESET line makes the card work again.

	Tan

> +};
> +
> +&hace {
> +	status = "okay";
> +	u-boot,dm-pre-reloc;
> +};
> +
> +&mac2 {
> +	status = "okay";
> +	phy-mode = "rgmii-id";
> +	phy-handle = <&ethphy2>;
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_rgmii3_default>;
> +};
> +
> +&mdio {
> +	status = "okay";
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_mdio3_default>;
> +	#address-cells = <1>;
> +	#size-cells = <0>;
> +
> +	ethphy2: ethernet-phy@2 {
> +		reg = <0>;
> +	};
> +};
> +
> +&sdrammc {
> +	clock-frequency = <400000000>;
> +};
> +
> +&uart5 {
> +	status = "okay";
> +	u-boot,dm-pre-reloc;
> +};
> +
> +&wdt1 {
> +	status = "okay";
> +};
> +
> +&wdt2 {
> +	status = "okay";
> +};
> +
> +&wdt3 {
> +	status = "okay";
> +};
>