Re: [PATCH v4 2/3] arm: dts: nuvoton: npcm7xx: Drop redundant FIU clock-names

On Wed, 10 Jun 2026 at 13:49, Andrew Jeffery
<[email protected]> wrote:
>
> On Tue, 2026-06-09 at 19:39 +0300, Tomer Maimon wrote:
> > The NPCM7xx FIU controller driver gets its single clock with
> > devm_clk_get_enabled(dev, NULL) and does not perform a named
> > clock lookup. Drop the redundant clock-names properties from the
> > FIU controller nodes so the DTS describes only the resources the
> > driver actually uses.
>
> The devicetree is a description of the hardware in the form documented
> by the bindings. Generally it's not right to discuss Linux drivers
> here: they're only relevant in the context of Linux, but the devicetree
> binding governs devicetrees over multiple projects.
>
> From a quick look it seems that these names are not described in the
> corresponding binding, therefore no drivers should be using them and as
> such they can (and should) be dropped. A driver would only be worth
> mentioning if it did use the undocumented names (as that would be a
> complication).
>
> Can you please rework the description?
do you mean change the description as follows
"
The NPCM7xx FIU controller nodes reference a single clock,
but the FIU binding does not describe their clock-names properties.
Drop the undocumented names so the DTS matches the binding.
"
>
> Andrew
>
> >
> > Signed-off-by: Tomer Maimon <[email protected]>
> > ---
> >  arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi | 3 ---
> >  1 file changed, 3 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi b/arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi
> > index a16450abea0e..83cd10b47273 100644
> > --- a/arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi
> > +++ b/arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi
> > @@ -193,7 +193,6 @@ fiu0: spi@fb000000 {
> >                       reg = <0xfb000000 0x1000>;
> >                       reg-names = "control";
> >                       clocks = <&clk NPCM7XX_CLK_SPI0>;
> > -                     clock-names = "clk_spi0";
> >                       status = "disabled";
> >               };
> >
> > @@ -204,7 +203,6 @@ fiu3: spi@c0000000 {
> >                       reg = <0xc0000000 0x1000>;
> >                       reg-names = "control";
> >                       clocks = <&clk NPCM7XX_CLK_SPI3>;
> > -                     clock-names = "clk_spi3";
> >                       pinctrl-names = "default";
> >                       pinctrl-0 = <&spi3_pins>;
> >                       status = "disabled";
> > @@ -217,7 +215,6 @@ fiux: spi@fb001000 {
> >                       reg = <0xfb001000 0x1000>;
> >                       reg-names = "control";
> >                       clocks = <&clk NPCM7XX_CLK_SPIX>;
> > -                     clock-names = "clk_spix";
> >                       status = "disabled";
> >               };
> >

Thanks,

Tomer