Re: [PATCH v1] rtc: Use named initializers for arrays of i2c_device_data

Uwe Kleine-König (The Capable Hub) <[email protected]> Wed, 10 Jun 2026 19:07:17 +0200

Newsgroups	org.ozlabs.lists.openbmc,org.kernel.vger.linux-kernel,org.kernel.vger.linux-rtc
Message-ID	<aimZqlTywiFMrHr2@monoceros>

Hello Alexandre,

On Fri, May 15, 2026 at 05:47:20PM +0200, Uwe Kleine-König (The Capable Hub) wrote:
> While being less compact, using named initializers allows to more easily
> see which members of the structs are assigned which value without having
> to lookup the declaration of the struct. And it's also more robust
> against changes to the struct definition.
> 
> The mentioned robustness is relevant for a planned change to struct
> i2c_device_id that replaces .driver_data by an anonymous union.
> 
> While touching all these arrays, unify usage of whitespace and commas.
> 
> This patch doesn't modify the compiled arrays, only their representation
> in source form benefits. The former was confirmed with x86 and arm64
> builds.
> 
> Signed-off-by: Uwe Kleine-König (The Capable Hub) <[email protected]>

Is there a chance to still get this into 7.2-rc1?

Best regards
Uwe

signature.asc (application/pgp-signature, 488 B)