Re: [PATCH 20/42] drm: xlnx: zynqmp_dpsub: Use devm_of_reserved_mem_device_init()
"Pandey, Radhey Shyam" <[email protected]> Tue, 7 Jul 2026 14:43:20 +0530
| Newsgroups | org.ozlabs.lists.openbmc,dev.linux.lists.imx,dev.linux.lists.linux-staging,dev.linux.lists.linux-sunxi,org.freedesktop.lists.dri-devel,org.infradead.lists.linux-mediatek,org.kernel.vger.linux-arm-msm,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel,org.kernel.vger.linux-media,org.kernel.vger.linux-mips,org.kernel.vger.linux-mmc,org.kernel.vger.linux-remoteproc,org.kernel.vger.linux-sound,org.kernel.vger.linux-tegra,org.ozlabs.lists.linux-aspeed,org.ozlabs.lists.linuxppc-dev |
|---|---|
| Message-ID | <[email protected]> |
> Use the devres-managed devm_of_reserved_mem_device_init() instead of > the manual of_reserved_mem_device_init()/of_reserved_mem_device_release() > pair, letting the device resource manager handle cleanup automatically. > > Signed-off-by: Mukesh Ojha <[email protected]> Reviewed-by: Radhey Shyam Pandey <[email protected]> Thanks! > --- > drivers/gpu/drm/xlnx/zynqmp_dpsub.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/xlnx/zynqmp_dpsub.c b/drivers/gpu/drm/xlnx/zynqmp_dpsub.c > index 53ab1a2a5aaf..e93a7a299b52 100644 > --- a/drivers/gpu/drm/xlnx/zynqmp_dpsub.c > +++ b/drivers/gpu/drm/xlnx/zynqmp_dpsub.c > @@ -203,7 +203,7 @@ static int zynqmp_dpsub_probe(struct platform_device *pdev) > dma_set_max_seg_size(&pdev->dev, DMA_BIT_MASK(32)); > > /* Try the reserved memory. Proceed if there's none. */ > - of_reserved_mem_device_init(&pdev->dev); > + devm_of_reserved_mem_device_init(&pdev->dev); > > ret = zynqmp_dpsub_init_clocks(dpsub); > if (ret < 0) > @@ -255,7 +255,6 @@ static int zynqmp_dpsub_probe(struct platform_device *pdev) > pm_runtime_disable(&pdev->dev); > clk_disable_unprepare(dpsub->apb_clk); > err_mem: > - of_reserved_mem_device_release(&pdev->dev); > if (!dpsub->drm) > zynqmp_dpsub_release(dpsub); > return ret; > @@ -276,7 +275,6 @@ static void zynqmp_dpsub_remove(struct platform_device *pdev) > > pm_runtime_disable(&pdev->dev); > clk_disable_unprepare(dpsub->apb_clk); > - of_reserved_mem_device_release(&pdev->dev); > > if (!dpsub->drm) > zynqmp_dpsub_release(dpsub);