Re: [PATCH] optee: Check return value of tee_shm_get_va()
Markus Elfring via OP-TEE <[email protected]>
| Newsgroups | org.trustedfirmware.lists.op-tee,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
…
> +++ b/drivers/tee/optee/rpc.c
> @@ -393,6 +393,11 @@ static void handle_rpc_func_rpmb_frames(struct tee_context *ctx,
> params[0].u.memref.shm_offs);
> p1 = tee_shm_get_va(params[1].u.memref.shm,
> params[1].u.memref.shm_offs);
> + if (IS_ERR(p0) || IS_ERR(p1)) {
> + arg->ret = TEEC_ERROR_BAD_PARAMETERS;
> + goto out;
> + }
> +
> if (rpmb_route_frames(rdev, p0, params[0].u.memref.size, p1,
> params[1].u.memref.size)) {
> arg->ret = TEEC_ERROR_BAD_PARAMETERS;
…
How do you think about to use an additional label for the shown
error code assignment?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v7.0-rc2#n526
Regards,
Markus