Re: [PATCH 02/14] firmware: qcom: Add a generic PAS service
Trilok Soni via OP-TEE <[email protected]>
| Newsgroups | org.trustedfirmware.lists.op-tee,org.freedesktop.lists.dri-devel,org.infradead.lists.ath12k,org.kernel.vger.linux-arm-msm,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-media,org.kernel.vger.linux-remoteproc,org.kernel.vger.linux-wireless,org.kernel.vger.netdev |
|---|---|
| Message-ID | <[email protected]> |
On 3/6/2026 11:47 AM, Trilok Soni wrote: >> diff --git a/drivers/firmware/qcom/qcom_pas.c b/drivers/firmware/qcom/qcom_pas.c >> new file mode 100644 >> index 000000000000..dc04ff1b6be0 >> --- /dev/null >> +++ b/drivers/firmware/qcom/qcom_pas.c >> @@ -0,0 +1,295 @@ >> +// SPDX-License-Identifier: GPL-2.0 >> +/* >> + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. >> + */ >> + >> +#include <linux/delay.h> >> +#include <linux/device/devres.h> >> +#include <linux/firmware/qcom/qcom_pas.h> >> +#include <linux/of.h> >> +#include <linux/kernel.h> >> +#include <linux/module.h> >> +#include <linux/slab.h> > are you sure you are using functionalities from these header files? > > I couldn't find slab.h usage quickly and also qcom_scm.h. Can you please confirm? I scrolled this patch too fast. I can see slab.h usage, but not sure about qcom_scm.h.