Re: [PATCH 02/14] firmware: qcom: Add a generic PAS service
Sumit Garg via OP-TEE <[email protected]>
| Newsgroups | org.trustedfirmware.lists.op-tee,org.freedesktop.lists.dri-devel,org.infradead.lists.ath12k,org.kernel.vger.linux-arm-msm,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-media,org.kernel.vger.linux-remoteproc,org.kernel.vger.linux-wireless,org.kernel.vger.netdev |
|---|---|
| Message-ID | <aa5UtcfiIe78oj1S@sumit-xelite> |
On Fri, Mar 06, 2026 at 07:49:07AM -0800, Jeff Johnson wrote:
> On 3/6/2026 2:50 AM, Sumit Garg wrote:
>
> I missed one k-doc warning...
>
> > +/**
> > + * qcom_scm_pas_auth_and_reset() - Authenticate the given peripheral firmware
>
> s/scm_//
>
> Warning: drivers/firmware/qcom/qcom_pas.c:173 expecting prototype for
> qcom_scm_pas_auth_and_reset(). Prototype was for qcom_pas_auth_and_reset() instead
>
Thanks for the k-doc warnings report, I will fix them in the next
version.
-Sumit
> > + * and reset the remote processor
> > + * @pas_id: peripheral authentication service id
> > + *
> > + * Return 0 on success.
> > + */
> > +int qcom_pas_auth_and_reset(u32 pas_id)
> > +{
> > + if (ops_ptr)
> > + return ops_ptr->auth_and_reset(ops_ptr->dev, pas_id);
> > +
> > + return -ENODEV;
> > +}
>