Re: [PATCH 10/14] drm/msm: Switch to generic PAS TZ APIs
Sumit Garg via OP-TEE <[email protected]>
| Newsgroups | org.trustedfirmware.lists.op-tee,org.freedesktop.lists.dri-devel,org.infradead.lists.ath12k,org.kernel.vger.linux-arm-msm,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-media,org.kernel.vger.linux-remoteproc,org.kernel.vger.linux-wireless,org.kernel.vger.netdev |
|---|---|
| Message-ID | <acTzOTUVL6uYQZwh@sumit-xelite> |
On Wed, Mar 25, 2026 at 06:34:18AM +0200, Dmitry Baryshkov wrote: > On Fri, Mar 06, 2026 at 04:20:23PM +0530, Sumit Garg wrote: > > From: Sumit Garg <[email protected]> > > > > Switch drm/msm client drivers over to generic PAS TZ APIs. Generic PAS > > TZ service allows to support multiple TZ implementation backends like QTEE > > based SCM PAS service, OP-TEE based PAS service and any further future TZ > > backend service. > > > > Signed-off-by: Sumit Garg <[email protected]> > > --- > > drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 4 ++-- > > drivers/gpu/drm/msm/adreno/adreno_gpu.c | 11 ++++++----- > > 2 files changed, 8 insertions(+), 7 deletions(-) > > > > diff --git a/drivers/gpu/drm/msm/adreno/a5xx_gpu.c b/drivers/gpu/drm/msm/adreno/a5xx_gpu.c > > index ef9fd6171af7..3283852f9a14 100644 > > --- a/drivers/gpu/drm/msm/adreno/a5xx_gpu.c > > +++ b/drivers/gpu/drm/msm/adreno/a5xx_gpu.c > > @@ -5,7 +5,7 @@ > > #include <linux/kernel.h> > > #include <linux/types.h> > > #include <linux/cpumask.h> > > -#include <linux/firmware/qcom/qcom_scm.h> > > +#include <linux/firmware/qcom/qcom_pas.h> > > Missing `select QCOM_PAS`. Sure, I will add that in next spin. -Sumit > > > > #include <linux/pm_opp.h> > > #include <linux/nvmem-consumer.h> > > #include <linux/slab.h> > > @@ -653,7 +653,7 @@ static int a5xx_zap_shader_resume(struct msm_gpu *gpu) > > if (adreno_is_a506(adreno_gpu)) > > return 0; > > > > - ret = qcom_scm_set_remote_state(SCM_GPU_ZAP_SHADER_RESUME, GPU_PAS_ID); > > + ret = qcom_pas_set_remote_state(SCM_GPU_ZAP_SHADER_RESUME, GPU_PAS_ID); > > if (ret) > > DRM_ERROR("%s: zap-shader resume failed: %d\n", > > gpu->name, ret); > > -- > With best wishes > Dmitry >