Re: [PATCH v6 1/6] optee: ffa: Add NULL check in optee_ffa_lend_protmem
Sumit Garg via OP-TEE <[email protected]> Thu, 28 May 2026 00:25:56 +0530
| Newsgroups | org.trustedfirmware.lists.op-tee,dev.linux.lists.kvmarm,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <ahc-PMwAbFfo-4Q8@sumit-xelite> |
On Wed, May 27, 2026 at 03:02:31PM +0000, Mostafa Saleh wrote:
> Sashiko (locally) reports a possible null dereference under memory
> pressure due to the lack of validation of the allocated pointer.
>
> Fix that by adding the missing check.
>
> Fixes: 2b78d79cdf96 ("optee: FF-A: dynamic protected memory allocation")
> Signed-off-by: Mostafa Saleh <[email protected]>
> ---
> drivers/tee/optee/ffa_abi.c | 3 +++
> 1 file changed, 3 insertions(+)
Reviewed-by: Sumit Garg <[email protected]>
-Sumit
>
> diff --git a/drivers/tee/optee/ffa_abi.c b/drivers/tee/optee/ffa_abi.c
> index b4372fa268d0..633715b98625 100644
> --- a/drivers/tee/optee/ffa_abi.c
> +++ b/drivers/tee/optee/ffa_abi.c
> @@ -698,6 +698,9 @@ static int optee_ffa_lend_protmem(struct optee *optee, struct tee_shm *protmem,
> int rc;
>
> mem_attr = kzalloc_objs(*mem_attr, ma_count);
> + if (!mem_attr)
> + return -ENOMEM;
> +
> for (n = 0; n < ma_count; n++) {
> mem_attr[n].receiver = mem_attrs[n] & U16_MAX;
> mem_attr[n].attrs = mem_attrs[n] >> 16;
> --
> 2.54.0.746.g67dd491aae-goog
>