Re: [PATCH v8 07/14] remoteproc: qcom: Select QCOM_PAS generic service
Sumit Garg via OP-TEE <[email protected]>
| Newsgroups | org.trustedfirmware.lists.op-tee,org.freedesktop.lists.dri-devel,org.infradead.lists.ath12k,org.kernel.vger.linux-arm-msm,org.kernel.vger.linux-kernel,org.kernel.vger.linux-media,org.kernel.vger.linux-remoteproc,org.kernel.vger.linux-wireless,org.kernel.vger.netdev |
|---|---|
| Message-ID | <akSncWwMc9tntyD4@sumit-xelite> |
Hi Konrad, On Tue, Jun 30, 2026 at 02:37:59PM +0200, Konrad Dybcio wrote: > On 6/26/26 3:34 PM, Sumit Garg wrote: > > From: Sumit Garg <[email protected]> > > > > Select PAS generic service driver to enable support for multiple PAS > > backends like OP-TEE in addition to SCM. > > > > Tested-by: Mukesh Ojha <[email protected]> # Lemans > > Tested-by: Vignesh Viswanathan <[email protected]> # IPQ9650 > > Signed-off-by: Sumit Garg <[email protected]> > > --- > > drivers/remoteproc/Kconfig | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/remoteproc/Kconfig b/drivers/remoteproc/Kconfig > > index c521c744e7db..65befdbfa5f7 100644 > > --- a/drivers/remoteproc/Kconfig > > +++ b/drivers/remoteproc/Kconfig > > @@ -210,6 +210,7 @@ config QCOM_Q6V5_MSS > > select QCOM_Q6V5_COMMON > > select QCOM_RPROC_COMMON > > select QCOM_SCM > > + select QCOM_PAS > > This is a NOP, SCM already requires QCOM_PAS That's true but I think we should rather have explicit modules dependencies whose APIs are being used by their clients. QCOM_SCM is a special module in this case exporting direct SCM calls apart from being the backend for the PAS service. I would prefer explicit dependencies but let me know if you feel strongly otherwise. > > > help > > Say y here to support the Qualcomm self-authenticating modem > > subsystem based on Hexagon V5. The TrustZone based system is > > @@ -230,6 +231,7 @@ config QCOM_Q6V5_PAS > > select QCOM_Q6V5_COMMON > > select QCOM_RPROC_COMMON > > select QCOM_SCM > > + select QCOM_PAS > > Likewise > > > help > > Say y here to support the TrustZone based Peripheral Image Loader for > > the Qualcomm remote processors. This is commonly used to control > > @@ -282,7 +284,7 @@ config QCOM_WCNSS_PIL > > select QCOM_MDT_LOADER > > select QCOM_PIL_INFO > > select QCOM_RPROC_COMMON > > - select QCOM_SCM > > + select QCOM_PAS > > This is OK > > _however_ > > It leads to a situation where no back-ends can be enabled The TEE backend is enabled by default if ARCH_QCOM is enabled, if you agree then we can similarly enable SCM backend too. -Sumit