Re: [PATCH 02/17] spi: cadence_qspi: enable clock

Marek Vasut via U-Boot <[email protected]> Sun, 2 Aug 2026 05:31:27 +0200

Newsgroups	org.u-boot-project.lists.u-boot
Message-ID	<[email protected]>

On 8/1/26 2:04 PM, Ralph Siemsen wrote:
> On Fri, Jul 31, 2026 at 11:07 PM Kumar, Udit <[email protected]> wrote:
>>
>> On 7/31/2026 10:03 PM, Ralph Siemsen wrote:
>>> --- a/drivers/spi/cadence_qspi.c
>>> +++ b/drivers/spi/cadence_qspi.c
>>> @@ -253,6 +253,7 @@ static int cadence_spi_probe(struct udevice *bus)
>>>                        priv->ref_clk_hz = clk_get_rate(&clk);
>>>                        if (IS_ERR_VALUE(priv->ref_clk_hz))
>>>                                return priv->ref_clk_hz;
>>> +                     clk_enable(&clk);
>>
>> you should enable clock, before calling get_rate
> 
> Good point. I will move it up.
And while you do, send the patches separately so the CC list doesn't 
include everyone who ever contributed to U-Boot and then some.