Re: [PATCH 1/8] tools: mkeficapsule: Add support for parsing capsule params from config file

On Mon Jul 27, 2026 at 6:55 PM EEST, Balaji Selvanathan wrote:
> From: Sughosh Ganu <[email protected]>
>
> Add support for specifying the parameters needed for capsule
> generation through a config file, instead of passing them through
> command-line. Parameters for more than a single capsule file can be
> specified, resulting in generation of multiple capsules through a
> single invocation of the command.
>
> The config file can be passed to the mkeficapsule tool in such manner
>
>  $ ./tools/mkeficapsule -f <path/to/the/config/file>
>
> Signed-off-by: Sughosh Ganu <[email protected]>
> ---
>  tools/Kconfig              |  15 ++
>  tools/Makefile             |  10 +-
>  tools/eficapsule.h         | 101 +++++++++++++
>  tools/mkeficapsule.c       |  90 ++++++++----
>  tools/mkeficapsule_parse.c | 353 +++++++++++++++++++++++++++++++++++++++++++++
>  5 files changed, 533 insertions(+), 36 deletions(-)
>
> diff --git a/tools/Kconfig b/tools/Kconfig
> index ef33295b8ec..8e09427fbac 100644
> --- a/tools/Kconfig
> +++ b/tools/Kconfig
> @@ -114,6 +114,21 @@ config TOOLS_MKEFICAPSULE
>  	  optionally sign that file. If you want to enable UEFI capsule
>  	  update feature on your target, you certainly need this.
>
> +config EFI_CAPSULE_CFG_FILE
> +	string "Path to the EFI Capsule Config File"
> +	help
> +	  Path to the EFI capsule config file which provides the
> +	  parameters needed to build capsule(s). Parameters can be
> +	  provided for multiple payloads resulting in corresponding
> +	  capsule images being generated.
> +
> +config EFI_USE_CAPSULE_CFG_FILE
> +	bool "Use the config file for generating capsules"
> +	help
> +	  Boolean option used to specify if the EFI capsules are to
> +	  be generated through parameters specified via the config
> +	  file or through command line.

There were valid comments in [0] which don't seem to be addressed.
Also these options seem unused in this patch. If they are needed they belong to the patch that uses
them

[...]


[0] https://lore.kernel.org/u-boot/[email protected]/

Thanks
/Ilias