Re: [PATCH 00/15] rockchip: Miscellaneous RK35xx clock fixes

Hi Jonas,

On Thu, 30 Jul 2026 at 08:13, Jonas Karlman <[email protected]> wrote:
>
> This series fixes a few trivial copy-paste mistakes and other misc clock
> issues for RK35xx SoCs.
>
> Patch 1-3 fixes minor and very unlikely issues for plls
> Patch 4 fixes PPLL mode handling on RK3588/RK3576
> Patch 5 disable 'special pll handling' for RK3576 plls
> Patch 6-7,11-13 fixes trivial clock configuration errors
> Patch 8-9 fixes less trivial clock configuration errors
> Patch 14-15 remove unused GRF syscon lookups
>
> Some of these fixes has only been compile tested as it involves clocks
> or rates that is rarely used in U-Boot.
>
> The 'special pll handling' should ideally be moved into clk_rk3588
> driver, something that can be done in a future follow-up series.
>
> Jonas Karlman (15):
>   clk: rockchip: pll: Fix double use of postdiv1
>   clk: rockchip: pll: Always write the dsmpd flag
>   clk: rockchip: pll: Always write the k param
>   clk: rockchip: pll: Use PLL_FIXED_MODE flag on rk3588/rk3576 plls
>   clk: rockchip: pll: Limit special rk3588_pll handling to RK3588
>   clk: rockchip: rk3568: Fix trivial clock configuration errors
>   clk: rockchip: rk3588: Fix trivial clock configuration errors
>   clk: rockchip: rk3588: Fix possible divide by zero
>   clk: rockchip: rk3588: Fix ACLK_BUS_ROOT rate set during probe
>   clk: rockchip: rk3588: Use SPLL_HZ constant
>   clk: rockchip: rk3576: Fix trivial clock configuration errors
>   clk: rockchip: rk3528: Fix trivial clock configuration errors
>   clk: rockchip: rk3506: Fix trivial clock configuration errors
>   clk: rockchip: rk3568: Drop unused GRF syscon lookup
>   clk: rockchip: rk3588: Drop unused GRF syscon lookup
>
>  .../include/asm/arch-rockchip/cru_rk3568.h    |  1 -
>  .../include/asm/arch-rockchip/cru_rk3576.h    |  5 +-
>  .../include/asm/arch-rockchip/cru_rk3588.h    |  6 +-
>  drivers/clk/rockchip/clk_pll.c                | 56 ++++++++++---------
>  drivers/clk/rockchip/clk_rk3506.c             |  2 +
>  drivers/clk/rockchip/clk_rk3528.c             |  7 ++-
>  drivers/clk/rockchip/clk_rk3568.c             | 12 ++--
>  drivers/clk/rockchip/clk_rk3576.c             | 26 ++++-----
>  drivers/clk/rockchip/clk_rk3588.c             | 39 ++++++-------
>  9 files changed, 72 insertions(+), 82 deletions(-)
>
> --
> 2.54.0
>

Just to note that Quentin has done a very thorough review and I didn't
see anything else to mention, so I'm not going to send review tags on
this one.

Regards,
Simon