Re: [PATCH] MAINTAINERS: Add missing fragment for Versal Gen 2
Michal Simek <[email protected]>
| Newsgroups | org.u-boot-project.lists.u-boot |
|---|---|
| Message-ID | <[email protected]> |
On 8/12/26 15:08, Marek Vasut wrote: > On 8/12/26 1:28 PM, Michal Simek wrote: >> >> >> On 8/12/26 11:11, Marek Vasut wrote: >>> On 8/12/26 8:35 AM, Michal Simek wrote: >>>> >>>> >>>> On 8/10/26 13:37, Michal Simek wrote: >>>>> Versal Gen 2 and especially march-versal2 is not covered by own fragment >>>>> that's why add it. >>>>> >>>>> Signed-off-by: Michal Simek <[email protected]> >>>>> --- >>>>> >>>>> MAINTAINERS | 6 ++++++ >>>>> 1 file changed, 6 insertions(+) >>>>> >>>>> diff --git a/MAINTAINERS b/MAINTAINERS >>>>> index e1379a6a3e7e..eb48eea55c5a 100644 >>>>> --- a/MAINTAINERS >>>>> +++ b/MAINTAINERS >>>>> @@ -821,6 +821,12 @@ F: drivers/spi/cadence_ospi_versal.c >>>>> F: drivers/watchdog/xilinx_wwdt.c >>>>> N: (?<!uni)versal >>>>> +ARM VERSAL GEN 2 >>>>> +M: Michal Simek <[email protected]> >>>>> +S: Maintained >>>>> +T: git https://git.u-boot-project.org/u-boot/custodians/u-boot- >>>>> microblaze.git >>>>> +F: arch/arm/mach-versal2/ >>> Use "N: versal" instead for the globbing match . >>> >>> In fact, "N: (?<!uni)versal" above does not work ? >> >> nope >> >> Before >> $ ./scripts/get_maintainer.pl -f arch/arm/mach-versal2/ >> Tom Rini <[email protected]> (maintainer:ARM) >> Ilias Apalodimas <[email protected]> (maintainer:ARM) >> Michal Simek <[email protected]> (maintainer:ARM >> VERSAL,commit_signer:14/15=93%,authored:10/15=67%) > There ^ you are , what's the problem ? Yes, I'm listed - but under ARM VERSAL, which is a different SoC family. Versal Gen 2 is a completely different chip with different features. It only matches the ARM VERSAL entry because of the "versal" substring in the N: regex, not because they're the same chips. (FWIW keeping "Versal" in every new SoC name is very confusing). Also Gen 2 specific drivers/files are coming, and those should be attributed to the Versal Gen 2 not to the Versal. Creating the section now is what makes that correct - otherwise every new Versal2 file silently inherits the Versal. Thanks, Michal