Re: [PATCH v2 3/3] boot: image-fdt: Restore suppression of irrelevant ERROR message

On Tue Aug 11, 2026 at 6:16 PM CDT, Jonas Karlman wrote:
> The commit 623f6c5b6ab7 ("boot: image-fdt: free old dtb reservations")
> removed the suppression of ERROR messages when -EINVAL was returned due
> to the memory region not being part of the LMB memory map.
>
> This causes an irrelevant ERROR message during boot, e.g.:
>
>   Model: Radxa ROCK 3B
>   [...]
>   ERROR: reserving fdt memory region failed (addr=10f000 size=100 flags=2): -22
>
> or
>
>   Model: Rockchip RK3288 Asus Tinker Board S
>   [...]
>   ERROR: reserving fdt memory region failed (addr=fe000000 size=1000000 flags=4): -22
>
> FDT correctly contains reserved-memory for 10f000 or fe000000 and U-Boot
> correctly does not make these regions available in the LMB memory map:
>
>   memory[0]      [0x200000-0xefffffff], 0xefe00000 bytes, flags: none
>   memory[1]      [0x100000000-0x1ffffffff], 0x100000000 bytes, flags: none
>
> or
>
>   memory[0]      [0x0-0x7fffffff], 0x80000000 bytes, flags: none
>
> With lmb_alloc_mem() and lmb_free() both returning -EFAULT when the
> requested memory region is not part of the LMB memory map it should be
> safe to ignore these errors when FDT memreserve and reserved-memory is
> being processed.
>
> Print -EFAULT errors using a debug message to restore suppression of
> this irrelevant ERROR message when memory region is not part of the LMB
> memory map.
>
> Fixes: 623f6c5b6ab7 ("boot: image-fdt: free old dtb reservations")
> Signed-off-by: Jonas Karlman <[email protected]>
> ---
>  boot/image-fdt.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

Looked this series over and ran it locally to verify. It resolves the issues I
raised about error verbosity well. Thanks Jonas.

Reviewed-by: Randolph Sapp <[email protected]>