Re: [PATCH v2] mmc: zynq_sdhci: support Renesas RZ/N1

Marek Vasut via U-Boot <[email protected]>
Newsgroups org.u-boot-project.lists.u-boot
Message-ID <[email protected]>
On 8/14/26 8:30 PM, Ralph Siemsen wrote:

[...]

> +++ b/drivers/mmc/zynq_sdhci.c

[...]

> @@ -1152,13 +1177,13 @@ static int arasan_sdhci_probe(struct udevice *dev)
>   		}
>   	}
>   
> -	ret = clk_get_by_index(dev, 0, &clk);
> +	ret = clk_get_bulk(dev, &clks);
>   	if (ret < 0) {
> -		dev_err(dev, "failed to get clock\n");
> +		dev_err(dev, "failed to get clock(s)\n");


"failed to get clock(s) (%d)\n", ret);

Please fix globally.

>   		return ret;
>   	}
>   
> -	clock = clk_get_rate(&clk);
> +	clock = clk_get_rate(&clks.clks[0]);

Can the clock ever be non-first clock , i.e. do you need to handle 
clock-names DT property somehow ?

>   	if (IS_ERR_VALUE(clock)) {
>   		dev_err(dev, "failed to get rate\n");
>   		return clock;
[...]
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.