Re: [PATCH v8 04/11] pinctrl: k1: add IO power domain configuration support

Hi Eric,

On 00:40 Sun 02 Aug     , Eric Chung wrote:
> Dual-voltage GPIO banks default to 3.3V, but when externally supplied
> with 1.8V the internal logic must be explicitly reconfigured to match.
> 
> Add the ability to program IO power domain control registers through the
> APBC block. These registers require unlocking the AIB Secure Access
> Register (ASAR) before every read/write, since configuring a 1.8V domain
> while 3.3V is externally supplied can cause back-powering and pin damage.
> 
> Signed-off-by: Eric Chung <[email protected]>
> Reviewed-by: Yao Zi <[email protected]>
> 
Looks good, please
Reviewed-by: Yixun Lan <[email protected]>

> ---
> v7:
> - Remove the dependency on SYSCON.
> v6:
> - Use dev_read_phandle_with_args() to fetch "spacemit,apbc" instead.
> v5:
> - Use tabs for macro definition alignment.
> - Fix the missing power source argument.
> v3:
> - Add SYSCON dependency in Kconfig.
> - Fix not sorted issue in the driver.

-- 
Yixun Lan (dlan)