Re: [PATCH v2 1/4] i2c: k1: fix wrong bus speed setting
Yixun Lan <[email protected]>
| Newsgroups | org.u-boot-project.lists.u-boot |
|---|---|
| Message-ID | <[email protected]> |
hi Junhui,
On 11:40 Sat 15 Aug , Junhui Liu wrote:
> The controller bus mode should be selected according to the requested
> I2C bus speed. However, the driver currently passes the functional clock
> rate to k1_i2c_set_bus_speed(), so the selected mode does not reflect
> the requested bus speed.
>
> Fix this by reading the clock-frequency property from the Device Tree,
> defaulting to standard speed, and drop the unused clk_rate field.
>
> Fixes: 271546fb8e54 ("i2c: k1: add I2C driver support")
> Reviewed-by: Heiko Schocher <[email protected]>
> Signed-off-by: Junhui Liu <[email protected]>
> ---
> drivers/i2c/k1_i2c.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
Looks good to me
Reviewed-by: Yixun Lan <[email protected]>
--
Yixun Lan (dlan)